[BUG] Credit abuse in [PRACTICE]

Linguistie commented

2021-01-17 06:14:03 +01:00

(Migrated from github.com)

Got reported by a player that credits can be abused by finishing a map in practice mode (infinitely teleporting to a cp near a finishline and spamming it)

I haven't tried it myself yet, but I assume it's true

Got reported by a player that credits can be abused by finishing a map in practice mode (infinitely teleporting to a cp near a finishline and spamming it) I haven't tried it myself yet, but I assume it's true

SaengerItsWar commented

2021-01-17 12:27:31 +01:00

ok this is funny cause normaly practice mode dosent let u make any time but the style segmented but for this style there is a check for this in the timer and also for the tas module
this is the code for this wich is in the plugin twice

char sStyleSpecialString[sizeof(stylestrings_t::sSpecialString)];
	Shavit_GetStyleStrings(style, sSpecialString, sStyleSpecialString, sizeof(sStyleSpecialString));
	
	if (StrContains(sStyleSpecialString, "segments") != -1)
		return;
	
	if (!g_cvTasEnabled.BoolValue)
		if (StrContains(sStyleSpecialString, "tas") != -1)
			return;

ok this is funny cause normaly practice mode dosent let u make any time but the style segmented but for this style there is a check for this in the timer and also for the tas module this is the code for this wich is in the plugin twice ```sourcrpawn char sStyleSpecialString[sizeof(stylestrings_t::sSpecialString)]; Shavit_GetStyleStrings(style, sSpecialString, sStyleSpecialString, sizeof(sStyleSpecialString)); if (StrContains(sStyleSpecialString, "segments") != -1) return; if (!g_cvTasEnabled.BoolValue) if (StrContains(sStyleSpecialString, "tas") != -1) return; ```

Linguistie commented

2021-01-18 10:50:37 +01:00

(Migrated from github.com)

Well, I m using shavit 2.6.0 and this is what I just got

"[Timer] WARNING: You're now in practice mode. Your times WILL NOT be saved and will be only displayed to you!"

those don't go into the database, but they do post a time in chat
I'll try to test it again and see what might have caused the players to receive the credits

EDIT2: interesting, one of the players told me that he was able to do it on fur_fix but can't do it on stref_cairo, maybe it's somehow connected with switching tracks? He also said he was getting 5 credits and after switching to main and then back to bfur he started getting 10

I'll let you know if I figure it out

Well, I m using shavit 2.6.0 and this is what I just got ![image](https://user-images.githubusercontent.com/22871155/104899297-582f1300-5983-11eb-9c9c-b8d2cc2d2f9d.png) "[Timer] WARNING: You're now in practice mode. Your times WILL NOT be saved and will be only displayed to you!" those don't go into the database, but they do post a time in chat I'll try to test it again and see what might have caused the players to receive the credits EDIT2: interesting, one of the players told me that he was able to do it on fur_fix but can't do it on stref_cairo, maybe it's somehow connected with switching tracks? He also said he was getting 5 credits and after switching to main and then back to bfur he started getting 10 I'll let you know if I figure it out

Linguistie commented

2021-01-18 11:03:38 +01:00

(Migrated from github.com)

pic from a guy

![image](https://user-images.githubusercontent.com/22871155/104900793-2dde5500-5985-11eb-9483-4fc51bfc9cca.png) pic from a guy

SaengerItsWar commented

2021-01-18 17:20:26 +01:00

ok i fixed what you meant and thank you for the report :)
https://github.com/SaengerItsWar/shavit-credits/raw/R1ko-Shop-Core-Fork/plugins/shavit-credits.smx

ok i fixed what you meant and thank you for the report :) https://github.com/SaengerItsWar/shavit-credits/raw/R1ko-Shop-Core-Fork/plugins/shavit-credits.smx

Linguistie commented

2021-01-21 06:08:14 +01:00

(Migrated from github.com)

The issue is still there. All I needed to do is drop the new .smx file into plugins and nothing else, right? Well, looks like that didn't help, if I installed it correctly. Here are some screenshots.

The issue is still there. All I needed to do is drop the new .smx file into plugins and nothing else, right? Well, looks like that didn't help, if I installed it correctly. Here are some screenshots. ![image](https://user-images.githubusercontent.com/22871155/105282530-3f0ea800-5bb7-11eb-85c6-ebe7b0d672f6.png)

SaengerItsWar commented

2021-01-21 07:44:11 +01:00

Did you restart the Server or changed the map? and did you downloaded the right version? cause your output says Zephyrus-Store Version?

Linguistie commented

2021-01-21 12:01:25 +01:00

(Migrated from github.com)

I have changed tha map, yeah, these are several days old and the credits have been abused. No, I have not restarted the server, only sm plugins unloaded the old one, deleted from /plugins and put a new .smx in and sm plugins loaded it. I am using zephyrus-store version due to my shop being zephyrus, I got the .smx from directly downloading it

Linguistie commented

2021-01-21 12:01:55 +01:00

(Migrated from github.com)

I'll attempt downloading it again later today and see what happens

SaengerItsWar commented

2021-01-21 23:49:13 +01:00

could you give me your full styles.cfg and say me which style you are using of it so that can i reproduce this.

SaengerItsWar commented

2021-04-17 03:27:13 +02:00

sry it's been a while i finaly found what you mean and i fixed it now in this version

[BUG] Credit abuse in [PRACTICE] #8